f44969a5ab
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
45 lines
1.2 KiB
JavaScript
45 lines
1.2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag assignment of the exception parameter
|
|
* @author Stephen Murray <spmurrayzzz>
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("../ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow reassigning exceptions in `catch` clauses",
|
|
category: "Possible Errors",
|
|
recommended: true
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
/**
|
|
* Finds and reports references that are non initializer and writable.
|
|
* @param {Variable} variable - A variable to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkVariable(variable) {
|
|
astUtils.getModifyingReferences(variable.references).forEach(reference => {
|
|
context.report({ node: reference.identifier, message: "Do not assign to the exception parameter." });
|
|
});
|
|
}
|
|
|
|
return {
|
|
CatchClause(node) {
|
|
context.getDeclaredVariables(node).forEach(checkVariable);
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|