f44969a5ab
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
39 lines
1.1 KiB
JavaScript
39 lines
1.1 KiB
JavaScript
/**
|
||
* @fileoverview Rule to flag comparisons to null without a type-checking
|
||
* operator.
|
||
* @author Ian Christian Myers
|
||
*/
|
||
|
||
"use strict";
|
||
|
||
//------------------------------------------------------------------------------
|
||
// Rule Definition
|
||
//------------------------------------------------------------------------------
|
||
|
||
module.exports = {
|
||
meta: {
|
||
docs: {
|
||
description: "disallow `null` comparisons without type-checking operators",
|
||
category: "Best Practices",
|
||
recommended: false
|
||
},
|
||
|
||
schema: []
|
||
},
|
||
|
||
create(context) {
|
||
|
||
return {
|
||
|
||
BinaryExpression(node) {
|
||
const badOperator = node.operator === "==" || node.operator === "!=";
|
||
|
||
if (node.right.type === "Literal" && node.right.raw === "null" && badOperator ||
|
||
node.left.type === "Literal" && node.left.raw === "null" && badOperator) {
|
||
context.report({ node, message: "Use ‘===’ to compare with ‘null’." });
|
||
}
|
||
}
|
||
};
|
||
|
||
}
|
||
};
|