We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
39 lines
1 KiB
JavaScript
39 lines
1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use of arguments.callee and arguments.caller.
|
|
* @author Nicholas C. Zakas
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow the use of `arguments.caller` or `arguments.callee`",
|
|
category: "Best Practices",
|
|
recommended: false
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
return {
|
|
|
|
MemberExpression(node) {
|
|
const objectName = node.object.name,
|
|
propertyName = node.property.name;
|
|
|
|
if (objectName === "arguments" && !node.computed && propertyName && propertyName.match(/^calle[er]$/)) {
|
|
context.report({ node, message: "Avoid arguments.{{property}}.", data: { property: propertyName } });
|
|
}
|
|
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|