We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
89 lines
2.6 KiB
JavaScript
89 lines
2.6 KiB
JavaScript
/**
|
|
* @fileoverview Rule to enforce a particular function style
|
|
* @author Nicholas C. Zakas
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "enforce the consistent use of either `function` declarations or expressions",
|
|
category: "Stylistic Issues",
|
|
recommended: false
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
enum: ["declaration", "expression"]
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
allowArrowFunctions: {
|
|
type: "boolean"
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
]
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const style = context.options[0],
|
|
allowArrowFunctions = context.options[1] && context.options[1].allowArrowFunctions === true,
|
|
enforceDeclarations = (style === "declaration"),
|
|
stack = [];
|
|
|
|
const nodesToCheck = {
|
|
FunctionDeclaration(node) {
|
|
stack.push(false);
|
|
|
|
if (!enforceDeclarations && node.parent.type !== "ExportDefaultDeclaration") {
|
|
context.report({ node, message: "Expected a function expression." });
|
|
}
|
|
},
|
|
"FunctionDeclaration:exit"() {
|
|
stack.pop();
|
|
},
|
|
|
|
FunctionExpression(node) {
|
|
stack.push(false);
|
|
|
|
if (enforceDeclarations && node.parent.type === "VariableDeclarator") {
|
|
context.report({ node: node.parent, message: "Expected a function declaration." });
|
|
}
|
|
},
|
|
"FunctionExpression:exit"() {
|
|
stack.pop();
|
|
},
|
|
|
|
ThisExpression() {
|
|
if (stack.length > 0) {
|
|
stack[stack.length - 1] = true;
|
|
}
|
|
}
|
|
};
|
|
|
|
if (!allowArrowFunctions) {
|
|
nodesToCheck.ArrowFunctionExpression = function() {
|
|
stack.push(false);
|
|
};
|
|
|
|
nodesToCheck["ArrowFunctionExpression:exit"] = function(node) {
|
|
const hasThisExpr = stack.pop();
|
|
|
|
if (enforceDeclarations && !hasThisExpr && node.parent.type === "VariableDeclarator") {
|
|
context.report({ node: node.parent, message: "Expected a function declaration." });
|
|
}
|
|
};
|
|
}
|
|
|
|
return nodesToCheck;
|
|
|
|
}
|
|
};
|