dd5a4e1d75We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
59 lines
1.8 KiB
JavaScript
59 lines
1.8 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag when initializing to undefined
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("../ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow initializing variables to `undefined`",
|
|
category: "Variables",
|
|
recommended: false
|
|
},
|
|
|
|
schema: [],
|
|
|
|
fixable: "code"
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const sourceCode = context.getSourceCode();
|
|
|
|
return {
|
|
|
|
VariableDeclarator(node) {
|
|
const name = sourceCode.getText(node.id),
|
|
init = node.init && node.init.name,
|
|
scope = context.getScope(),
|
|
undefinedVar = astUtils.getVariableByName(scope, "undefined"),
|
|
shadowed = undefinedVar && undefinedVar.defs.length > 0;
|
|
|
|
if (init === "undefined" && node.parent.kind !== "const" && !shadowed) {
|
|
context.report({
|
|
node,
|
|
message: "It's not necessary to initialize '{{name}}' to undefined.",
|
|
data: { name },
|
|
fix(fixer) {
|
|
if (node.id.type === "ArrayPattern" || node.id.type === "ObjectPattern") {
|
|
|
|
// Don't fix destructuring assignment to `undefined`.
|
|
return null;
|
|
}
|
|
return fixer.removeRange([node.id.range[1], node.range[1]]);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|