dd5a4e1d75We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
40 lines
1.2 KiB
JavaScript
40 lines
1.2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag comparison where left part is the same as the right
|
|
* part.
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow comparisons where both sides are exactly the same",
|
|
category: "Best Practices",
|
|
recommended: false
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
return {
|
|
|
|
BinaryExpression(node) {
|
|
const operators = ["===", "==", "!==", "!=", ">", "<", ">=", "<="];
|
|
|
|
if (operators.indexOf(node.operator) > -1 &&
|
|
(node.left.type === "Identifier" && node.right.type === "Identifier" && node.left.name === node.right.name ||
|
|
node.left.type === "Literal" && node.right.type === "Literal" && node.left.value === node.right.value)) {
|
|
context.report({ node, message: "Comparing to itself is potentially pointless." });
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|