dd5a4e1d75We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
66 lines
2 KiB
JavaScript
66 lines
2 KiB
JavaScript
/**
|
|
* @fileoverview A rule to warn against using arrow functions when they could be
|
|
* confused with comparisions
|
|
* @author Jxck <https://github.com/Jxck>
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("../ast-utils.js");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks whether or not a node is a conditional expression.
|
|
* @param {ASTNode} node - node to test
|
|
* @returns {boolean} `true` if the node is a conditional expression.
|
|
*/
|
|
function isConditional(node) {
|
|
return node && node.type === "ConditionalExpression";
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow arrow functions where they could be confused with comparisons",
|
|
category: "ECMAScript 6",
|
|
recommended: false
|
|
},
|
|
|
|
schema: [{
|
|
type: "object",
|
|
properties: {
|
|
allowParens: { type: "boolean" }
|
|
},
|
|
additionalProperties: false
|
|
}]
|
|
},
|
|
|
|
create(context) {
|
|
const config = context.options[0] || {};
|
|
const sourceCode = context.getSourceCode();
|
|
|
|
/**
|
|
* Reports if an arrow function contains an ambiguous conditional.
|
|
* @param {ASTNode} node - A node to check and report.
|
|
* @returns {void}
|
|
*/
|
|
function checkArrowFunc(node) {
|
|
const body = node.body;
|
|
|
|
if (isConditional(body) && !(config.allowParens && astUtils.isParenthesised(sourceCode, body))) {
|
|
context.report({ node, message: "Arrow function used ambiguously with a conditional expression." });
|
|
}
|
|
}
|
|
|
|
return {
|
|
ArrowFunctionExpression: checkArrowFunc
|
|
};
|
|
}
|
|
};
|