dd5a4e1d75We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
54 lines
1.5 KiB
JavaScript
54 lines
1.5 KiB
JavaScript
/**
|
|
* @fileoverview A rule to disallow modifying variables of class declarations
|
|
* @author Toru Nagashima
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("../ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow reassigning class members",
|
|
category: "ECMAScript 6",
|
|
recommended: true
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
/**
|
|
* Finds and reports references that are non initializer and writable.
|
|
* @param {Variable} variable - A variable to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkVariable(variable) {
|
|
astUtils.getModifyingReferences(variable.references).forEach(reference => {
|
|
context.report({ node: reference.identifier, message: "'{{name}}' is a class.", data: { name: reference.identifier.name } });
|
|
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Finds and reports references that are non initializer and writable.
|
|
* @param {ASTNode} node - A ClassDeclaration/ClassExpression node to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkForClass(node) {
|
|
context.getDeclaredVariables(node).forEach(checkVariable);
|
|
}
|
|
|
|
return {
|
|
ClassDeclaration: checkForClass,
|
|
ClassExpression: checkForClass
|
|
};
|
|
|
|
}
|
|
};
|