c342bda49e
Check that invoking a callback on a receiver from a different context works. It ran afoul of an `env->context() == isolate->GetCurrentContext()` assertion so retrieve the environment from the callback context and the context to enter from the environment's context() method. We could also have retrieved the environment from the receiver's context and that would have made little practical difference. It just seemed more correct to get it from the callback context because that is the actual execution context. PR-URL: https://github.com/nodejs/node/pull/9221 Reviewed-By: Anna Henningsen <anna@addaleax.net>
65 lines
1.8 KiB
JavaScript
65 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
const binding = require(`./build/${common.buildType}/binding`);
|
|
const makeCallback = binding.makeCallback;
|
|
|
|
assert.strictEqual(42, makeCallback(process, common.mustCall(function() {
|
|
assert.strictEqual(0, arguments.length);
|
|
assert.strictEqual(this, process);
|
|
return 42;
|
|
})));
|
|
|
|
assert.strictEqual(42, makeCallback(process, common.mustCall(function(x) {
|
|
assert.strictEqual(1, arguments.length);
|
|
assert.strictEqual(this, process);
|
|
assert.strictEqual(x, 1337);
|
|
return 42;
|
|
}), 1337));
|
|
|
|
const recv = {
|
|
one: common.mustCall(function() {
|
|
assert.strictEqual(0, arguments.length);
|
|
assert.strictEqual(this, recv);
|
|
return 42;
|
|
}),
|
|
two: common.mustCall(function(x) {
|
|
assert.strictEqual(1, arguments.length);
|
|
assert.strictEqual(this, recv);
|
|
assert.strictEqual(x, 1337);
|
|
return 42;
|
|
}),
|
|
};
|
|
|
|
assert.strictEqual(42, makeCallback(recv, 'one'));
|
|
assert.strictEqual(42, makeCallback(recv, 'two', 1337));
|
|
|
|
// Check that callbacks on a receiver from a different context works.
|
|
const foreignObject = vm.runInNewContext('({ fortytwo() { return 42; } })');
|
|
assert.strictEqual(42, makeCallback(foreignObject, 'fortytwo'));
|
|
|
|
// Check that the callback is made in the context of the receiver.
|
|
const target = vm.runInNewContext(`
|
|
(function($Object) {
|
|
if (Object === $Object)
|
|
throw new Error('bad');
|
|
return Object;
|
|
})
|
|
`);
|
|
assert.notStrictEqual(Object, makeCallback(process, target, Object));
|
|
|
|
// Runs in inner context.
|
|
const forward = vm.runInNewContext(`
|
|
(function(forward) {
|
|
return forward(Object);
|
|
})
|
|
`);
|
|
// Runs in outer context.
|
|
const endpoint = function($Object) {
|
|
if (Object === $Object)
|
|
throw new Error('bad');
|
|
return Object;
|
|
};
|
|
assert.strictEqual(Object, makeCallback(process, forward, endpoint));
|