688e5ed6fdThis change removes `common.noop` from the Node.js internal testing
common module.
Over the last few weeks, I've grown to dislike the `common.noop`
abstraction.
First, new (and experienced) contributors are unaware of it and so it
results in a large number of low-value nits on PRs. It also increases
the number of things newcomers and infrequent contributors have to be
aware of to be effective on the project.
Second, it is confusing. Is it a singleton/property or a getter? Which
should be expected? This can lead to subtle and hard-to-find bugs. (To
my knowledge, none have landed on master. But I also think it's only a
matter of time.)
Third, the abstraction is low-value in my opinion. What does it really
get us? A case could me made that it is without value at all.
Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. `common.noop` doesn't save anything over `() => {}`.
So, I propose removing it.
PR-URL: https://github.com/nodejs/node/pull/12822
Backport-PR-URL: https://github.com/nodejs/node/pull/14174
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
134 lines
5.5 KiB
JavaScript
134 lines
5.5 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
const context = require('vm').runInNewContext;
|
|
|
|
// isArray
|
|
assert.strictEqual(true, util.isArray([]));
|
|
assert.strictEqual(true, util.isArray(Array()));
|
|
assert.strictEqual(true, util.isArray(new Array()));
|
|
assert.strictEqual(true, util.isArray(new Array(5)));
|
|
assert.strictEqual(true, util.isArray(new Array('with', 'some', 'entries')));
|
|
assert.strictEqual(true, util.isArray(context('Array')()));
|
|
assert.strictEqual(false, util.isArray({}));
|
|
assert.strictEqual(false, util.isArray({ push: () => {} }));
|
|
assert.strictEqual(false, util.isArray(/regexp/));
|
|
assert.strictEqual(false, util.isArray(new Error()));
|
|
assert.strictEqual(false, util.isArray(Object.create(Array.prototype)));
|
|
|
|
// isRegExp
|
|
assert.strictEqual(true, util.isRegExp(/regexp/));
|
|
assert.strictEqual(true, util.isRegExp(RegExp()));
|
|
assert.strictEqual(true, util.isRegExp(new RegExp()));
|
|
assert.strictEqual(true, util.isRegExp(context('RegExp')()));
|
|
assert.strictEqual(false, util.isRegExp({}));
|
|
assert.strictEqual(false, util.isRegExp([]));
|
|
assert.strictEqual(false, util.isRegExp(new Date()));
|
|
assert.strictEqual(false, util.isRegExp(Object.create(RegExp.prototype)));
|
|
|
|
// isDate
|
|
assert.strictEqual(true, util.isDate(new Date()));
|
|
assert.strictEqual(true, util.isDate(new Date(0)));
|
|
// eslint-disable-next-line new-parens
|
|
assert.strictEqual(true, util.isDate(new (context('Date'))));
|
|
assert.strictEqual(false, util.isDate(Date()));
|
|
assert.strictEqual(false, util.isDate({}));
|
|
assert.strictEqual(false, util.isDate([]));
|
|
assert.strictEqual(false, util.isDate(new Error()));
|
|
assert.strictEqual(false, util.isDate(Object.create(Date.prototype)));
|
|
|
|
// isError
|
|
assert.strictEqual(true, util.isError(new Error()));
|
|
assert.strictEqual(true, util.isError(new TypeError()));
|
|
assert.strictEqual(true, util.isError(new SyntaxError()));
|
|
/* eslint-disable new-parens */
|
|
assert.strictEqual(true, util.isError(new (context('Error'))));
|
|
assert.strictEqual(true, util.isError(new (context('TypeError'))));
|
|
assert.strictEqual(true, util.isError(new (context('SyntaxError'))));
|
|
/* eslint-enable */
|
|
assert.strictEqual(false, util.isError({}));
|
|
assert.strictEqual(false, util.isError({ name: 'Error', message: '' }));
|
|
assert.strictEqual(false, util.isError([]));
|
|
assert.strictEqual(true, util.isError(Object.create(Error.prototype)));
|
|
|
|
// isObject
|
|
assert.ok(util.isObject({}) === true);
|
|
|
|
// isPrimitive
|
|
assert.strictEqual(false, util.isPrimitive({}));
|
|
assert.strictEqual(false, util.isPrimitive(new Error()));
|
|
assert.strictEqual(false, util.isPrimitive(new Date()));
|
|
assert.strictEqual(false, util.isPrimitive([]));
|
|
assert.strictEqual(false, util.isPrimitive(/regexp/));
|
|
assert.strictEqual(false, util.isPrimitive(() => {}));
|
|
assert.strictEqual(false, util.isPrimitive(new Number(1)));
|
|
assert.strictEqual(false, util.isPrimitive(new String('bla')));
|
|
assert.strictEqual(false, util.isPrimitive(new Boolean(true)));
|
|
assert.strictEqual(true, util.isPrimitive(1));
|
|
assert.strictEqual(true, util.isPrimitive('bla'));
|
|
assert.strictEqual(true, util.isPrimitive(true));
|
|
assert.strictEqual(true, util.isPrimitive(undefined));
|
|
assert.strictEqual(true, util.isPrimitive(null));
|
|
assert.strictEqual(true, util.isPrimitive(Infinity));
|
|
assert.strictEqual(true, util.isPrimitive(NaN));
|
|
assert.strictEqual(true, util.isPrimitive(Symbol('symbol')));
|
|
|
|
// isBuffer
|
|
assert.strictEqual(false, util.isBuffer('foo'));
|
|
assert.strictEqual(true, util.isBuffer(Buffer.from('foo')));
|
|
|
|
// _extend
|
|
assert.deepStrictEqual(util._extend({a: 1}), {a: 1});
|
|
assert.deepStrictEqual(util._extend({a: 1}, []), {a: 1});
|
|
assert.deepStrictEqual(util._extend({a: 1}, null), {a: 1});
|
|
assert.deepStrictEqual(util._extend({a: 1}, true), {a: 1});
|
|
assert.deepStrictEqual(util._extend({a: 1}, false), {a: 1});
|
|
assert.deepStrictEqual(util._extend({a: 1}, {b: 2}), {a: 1, b: 2});
|
|
assert.deepStrictEqual(util._extend({a: 1, b: 2}, {b: 3}), {a: 1, b: 3});
|
|
|
|
// deprecated
|
|
assert.strictEqual(util.isBoolean(true), true);
|
|
assert.strictEqual(util.isBoolean(false), true);
|
|
assert.strictEqual(util.isBoolean('string'), false);
|
|
|
|
assert.strictEqual(util.isNull(null), true);
|
|
assert.strictEqual(util.isNull(), false);
|
|
assert.strictEqual(util.isNull('string'), false);
|
|
|
|
assert.strictEqual(util.isUndefined(), true);
|
|
assert.strictEqual(util.isUndefined(null), false);
|
|
assert.strictEqual(util.isUndefined('string'), false);
|
|
|
|
assert.strictEqual(util.isNullOrUndefined(null), true);
|
|
assert.strictEqual(util.isNullOrUndefined(), true);
|
|
assert.strictEqual(util.isNullOrUndefined('string'), false);
|
|
|
|
assert.strictEqual(util.isNumber(42), true);
|
|
assert.strictEqual(util.isNumber(), false);
|
|
assert.strictEqual(util.isNumber('string'), false);
|
|
|
|
assert.strictEqual(util.isString('string'), true);
|
|
assert.strictEqual(util.isString(), false);
|
|
assert.strictEqual(util.isString(42), false);
|
|
|
|
assert.strictEqual(util.isSymbol(Symbol()), true);
|
|
assert.strictEqual(util.isSymbol(), false);
|
|
assert.strictEqual(util.isSymbol('string'), false);
|
|
|
|
assert.strictEqual(util.isFunction(() => {}), true);
|
|
assert.strictEqual(util.isFunction(() => {}), true);
|
|
assert.strictEqual(util.isFunction(), false);
|
|
assert.strictEqual(util.isFunction('string'), false);
|
|
|
|
common.expectWarning('DeprecationWarning', [
|
|
'util.print is deprecated. Use console.log instead.',
|
|
'util.puts is deprecated. Use console.log instead.',
|
|
'util.debug is deprecated. Use console.error instead.',
|
|
'util.error is deprecated. Use console.error instead.'
|
|
]);
|
|
|
|
util.print('test');
|
|
util.puts('test');
|
|
util.debug('test');
|
|
util.error('test');
|