9cfec4ba0f* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. Backport-PR-URL: https://github.com/nodejs/node/pull/14370 PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
41 lines
1.3 KiB
JavaScript
41 lines
1.3 KiB
JavaScript
// Flags: --no-warnings
|
|
// The flag suppresses stderr output but the warning event will still emit
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
|
|
process.on('warning', common.mustCall((warning) => {
|
|
assert(warning);
|
|
assert(/^(?:Warning|CustomWarning)/.test(warning.name));
|
|
assert(warning.message, 'A Warning');
|
|
}, 7));
|
|
|
|
process.emitWarning('A Warning');
|
|
process.emitWarning('A Warning', 'CustomWarning');
|
|
process.emitWarning('A Warning', CustomWarning);
|
|
process.emitWarning('A Warning', 'CustomWarning', CustomWarning);
|
|
|
|
function CustomWarning() {
|
|
Error.call(this);
|
|
this.name = 'CustomWarning';
|
|
this.message = 'A Warning';
|
|
Error.captureStackTrace(this, CustomWarning);
|
|
}
|
|
util.inherits(CustomWarning, Error);
|
|
process.emitWarning(new CustomWarning());
|
|
|
|
const warningNoToString = new CustomWarning();
|
|
warningNoToString.toString = null;
|
|
process.emitWarning(warningNoToString);
|
|
|
|
const warningThrowToString = new CustomWarning();
|
|
warningThrowToString.toString = function() {
|
|
throw new Error('invalid toString');
|
|
};
|
|
process.emitWarning(warningThrowToString);
|
|
|
|
// TypeError is thrown on invalid output
|
|
assert.throws(() => process.emitWarning(1), TypeError);
|
|
assert.throws(() => process.emitWarning({}), TypeError);
|