9cfec4ba0f* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. Backport-PR-URL: https://github.com/nodejs/node/pull/14370 PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
56 lines
2.2 KiB
JavaScript
56 lines
2.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
|
|
function check(async, sync) {
|
|
const expected = /Path must be a string without null bytes/;
|
|
const argsSync = Array.prototype.slice.call(arguments, 2);
|
|
const argsAsync = argsSync.concat((er) => {
|
|
assert(er && expected.test(er.message));
|
|
assert.strictEqual(er.code, 'ENOENT');
|
|
});
|
|
|
|
if (sync)
|
|
assert.throws(() => {
|
|
sync.apply(null, argsSync);
|
|
}, expected);
|
|
|
|
if (async)
|
|
async.apply(null, argsAsync);
|
|
}
|
|
|
|
check(fs.access, fs.accessSync, 'foo\u0000bar');
|
|
check(fs.access, fs.accessSync, 'foo\u0000bar', fs.F_OK);
|
|
check(fs.appendFile, fs.appendFileSync, 'foo\u0000bar', 'abc');
|
|
check(fs.chmod, fs.chmodSync, 'foo\u0000bar', '0644');
|
|
check(fs.chown, fs.chownSync, 'foo\u0000bar', 12, 34);
|
|
check(fs.link, fs.linkSync, 'foo\u0000bar', 'foobar');
|
|
check(fs.link, fs.linkSync, 'foobar', 'foo\u0000bar');
|
|
check(fs.lstat, fs.lstatSync, 'foo\u0000bar');
|
|
check(fs.mkdir, fs.mkdirSync, 'foo\u0000bar', '0755');
|
|
check(fs.open, fs.openSync, 'foo\u0000bar', 'r');
|
|
check(fs.readFile, fs.readFileSync, 'foo\u0000bar');
|
|
check(fs.readdir, fs.readdirSync, 'foo\u0000bar');
|
|
check(fs.readlink, fs.readlinkSync, 'foo\u0000bar');
|
|
check(fs.realpath, fs.realpathSync, 'foo\u0000bar');
|
|
check(fs.rename, fs.renameSync, 'foo\u0000bar', 'foobar');
|
|
check(fs.rename, fs.renameSync, 'foobar', 'foo\u0000bar');
|
|
check(fs.rmdir, fs.rmdirSync, 'foo\u0000bar');
|
|
check(fs.stat, fs.statSync, 'foo\u0000bar');
|
|
check(fs.symlink, fs.symlinkSync, 'foo\u0000bar', 'foobar');
|
|
check(fs.symlink, fs.symlinkSync, 'foobar', 'foo\u0000bar');
|
|
check(fs.truncate, fs.truncateSync, 'foo\u0000bar');
|
|
check(fs.unlink, fs.unlinkSync, 'foo\u0000bar');
|
|
check(null, fs.unwatchFile, 'foo\u0000bar', common.fail);
|
|
check(fs.utimes, fs.utimesSync, 'foo\u0000bar', 0, 0);
|
|
check(null, fs.watch, 'foo\u0000bar', common.fail);
|
|
check(null, fs.watchFile, 'foo\u0000bar', common.fail);
|
|
check(fs.writeFile, fs.writeFileSync, 'foo\u0000bar', 'abc');
|
|
|
|
// an 'error' for exists means that it doesn't exist.
|
|
// one of many reasons why this file is the absolute worst.
|
|
fs.exists('foo\u0000bar', common.mustCall((exists) => {
|
|
assert(!exists);
|
|
}));
|
|
assert(!fs.existsSync('foo\u0000bar'));
|