9cfec4ba0f* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. Backport-PR-URL: https://github.com/nodejs/node/pull/14370 PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
64 lines
1.9 KiB
JavaScript
64 lines
1.9 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const exec = require('child_process').exec;
|
|
const path = require('path');
|
|
|
|
function errExec(script, callback) {
|
|
const cmd = `"${process.argv[0]}" "${path.join(common.fixturesDir, script)}"`;
|
|
return exec(cmd, function(err, stdout, stderr) {
|
|
// There was some error
|
|
assert.ok(err);
|
|
|
|
// More than one line of error output.
|
|
assert.ok(stderr.split('\n').length > 2);
|
|
|
|
// Assert the script is mentioned in error output.
|
|
assert.ok(stderr.includes(script));
|
|
|
|
// Proxy the args for more tests.
|
|
callback(err, stdout, stderr);
|
|
});
|
|
}
|
|
|
|
const syntaxErrorMessage = /SyntaxError/;
|
|
|
|
|
|
// Simple throw error
|
|
errExec('throws_error.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/blah/.test(stderr));
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined)
|
|
errExec('throws_error2.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(syntaxErrorMessage.test(stderr));
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined) in nextTick
|
|
errExec('throws_error3.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(syntaxErrorMessage.test(stderr));
|
|
}));
|
|
|
|
|
|
// throw ILLEGAL error
|
|
errExec('throws_error4.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/\/\*\*/.test(stderr));
|
|
assert.ok(syntaxErrorMessage.test(stderr));
|
|
}));
|
|
|
|
// Specific long exception line doesn't result in stack overflow
|
|
errExec('throws_error5.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(syntaxErrorMessage.test(stderr));
|
|
}));
|
|
|
|
// Long exception line with length > errorBuffer doesn't result in assertion
|
|
errExec('throws_error6.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(syntaxErrorMessage.test(stderr));
|
|
}));
|
|
|
|
// Object that throws in toString() doesn't print garbage
|
|
errExec('throws_error7.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/<toString\(\) threw exception/.test(stderr));
|
|
}));
|