Adds a new `../common/fixtures' module to begin normalizing `test/fixtures` use. Our test code is a bit inconsistent with regards to use of the fixtures directory. Some code uses `path.join()`, some code uses string concats, some other code uses template strings, etc. In mnay cases, significant duplication of code is seen when accessing fixture files, etc. This updates many (but by no means all) of the tests in the test suite to use the new consistent API. There are still many more to update, which would make an excelent Code-n-Learn exercise. Backport-PR-URL: https://github.com/nodejs/node/pull/16265 PR-URL: https://github.com/nodejs/node/pull/14332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
20 lines
682 B
JavaScript
20 lines
682 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const exitScript = fixtures.path('exit.js');
|
|
const exitChild = spawn(process.argv[0], [exitScript, 23]);
|
|
exitChild.on('exit', common.mustCall(function(code, signal) {
|
|
assert.strictEqual(code, 23);
|
|
assert.strictEqual(signal, null);
|
|
}));
|
|
|
|
|
|
const errorScript = fixtures.path('child_process_should_emit_error.js');
|
|
const errorChild = spawn(process.argv[0], [errorScript]);
|
|
errorChild.on('exit', common.mustCall(function(code, signal) {
|
|
assert.ok(code !== 0);
|
|
assert.strictEqual(signal, null);
|
|
}));
|