f601d040b5
Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
92 lines
3 KiB
JavaScript
92 lines
3 KiB
JavaScript
/**
|
|
* @fileoverview A rule to suggest using of the spread operator instead of `.apply()`.
|
|
* @author Toru Nagashima
|
|
* @copyright 2015 Toru Nagashima. All rights reserved.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
var astUtils = require("../ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks whether or not a node is a `.apply()` for variadic.
|
|
* @param {ASTNode} node - A CallExpression node to check.
|
|
* @returns {boolean} Whether or not the node is a `.apply()` for variadic.
|
|
*/
|
|
function isVariadicApplyCalling(node) {
|
|
return (
|
|
node.callee.type === "MemberExpression" &&
|
|
node.callee.property.type === "Identifier" &&
|
|
node.callee.property.name === "apply" &&
|
|
node.callee.computed === false &&
|
|
node.arguments.length === 2 &&
|
|
node.arguments[1].type !== "ArrayExpression"
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks whether or not the tokens of two given nodes are same.
|
|
* @param {ASTNode} left - A node 1 to compare.
|
|
* @param {ASTNode} right - A node 2 to compare.
|
|
* @param {RuleContext} context - The ESLint rule context object.
|
|
* @returns {boolean} the source code for the given node.
|
|
*/
|
|
function equalTokens(left, right, context) {
|
|
var tokensL = context.getTokens(left);
|
|
var tokensR = context.getTokens(right);
|
|
|
|
if (tokensL.length !== tokensR.length) {
|
|
return false;
|
|
}
|
|
for (var i = 0; i < tokensL.length; ++i) {
|
|
if (tokensL[i].type !== tokensR[i].type ||
|
|
tokensL[i].value !== tokensR[i].value
|
|
) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* Checks whether or not `thisArg` is not changed by `.apply()`.
|
|
* @param {ASTNode|null} expectedThis - The node that is the owner of the applied function.
|
|
* @param {ASTNode} thisArg - The node that is given to the first argument of the `.apply()`.
|
|
* @param {RuleContext} context - The ESLint rule context object.
|
|
* @returns {boolean} Whether or not `thisArg` is not changed by `.apply()`.
|
|
*/
|
|
function isValidThisArg(expectedThis, thisArg, context) {
|
|
if (!expectedThis) {
|
|
return astUtils.isNullOrUndefined(thisArg);
|
|
}
|
|
return equalTokens(expectedThis, thisArg, context);
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
return {
|
|
"CallExpression": function(node) {
|
|
if (!isVariadicApplyCalling(node)) {
|
|
return;
|
|
}
|
|
|
|
var applied = node.callee.object;
|
|
var expectedThis = (applied.type === "MemberExpression") ? applied.object : null;
|
|
var thisArg = node.arguments[0];
|
|
|
|
if (isValidThisArg(expectedThis, thisArg, context)) {
|
|
context.report(node, "use the spread operator instead of the '.apply()'.");
|
|
}
|
|
}
|
|
};
|
|
};
|
|
|
|
module.exports.schema = [];
|