d9b8758f47
PR-URL: https://github.com/nodejs/node/pull/6132 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
75 lines
2 KiB
JavaScript
75 lines
2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to
|
|
* @author Toru Nagashima
|
|
* @copyright 2015 Toru Nagashima. All rights reserved.
|
|
* See LICENSE file in root directory for full license.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Gets the variable object of `arguments` which is defined implicitly.
|
|
* @param {escope.Scope} scope - A scope to get.
|
|
* @returns {escope.Variable} The found variable object.
|
|
*/
|
|
function getVariableOfArguments(scope) {
|
|
var variables = scope.variables;
|
|
|
|
for (var i = 0; i < variables.length; ++i) {
|
|
var variable = variables[i];
|
|
|
|
if (variable.name === "arguments") {
|
|
|
|
// If there was a parameter which is named "arguments", the implicit "arguments" is not defined.
|
|
// So does fast return with null.
|
|
return (variable.identifiers.length === 0) ? variable : null;
|
|
}
|
|
}
|
|
|
|
/* istanbul ignore next : unreachable */
|
|
return null;
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
/**
|
|
* Reports a given reference.
|
|
*
|
|
* @param {escope.Reference} reference - A reference to report.
|
|
* @returns {void}
|
|
*/
|
|
function report(reference) {
|
|
context.report({
|
|
node: reference.identifier,
|
|
message: "Use the rest parameters instead of 'arguments'."
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Reports references of the implicit `arguments` variable if exist.
|
|
*
|
|
* @returns {void}
|
|
*/
|
|
function checkForArguments() {
|
|
var argumentsVar = getVariableOfArguments(context.getScope());
|
|
|
|
if (argumentsVar) {
|
|
argumentsVar.references.forEach(report);
|
|
}
|
|
}
|
|
|
|
return {
|
|
FunctionDeclaration: checkForArguments,
|
|
FunctionExpression: checkForArguments
|
|
};
|
|
};
|
|
|
|
module.exports.schema = [];
|