f601d040b5
Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
70 lines
2.3 KiB
JavaScript
70 lines
2.3 KiB
JavaScript
/**
|
|
* @fileoverview Rule to spot scenarios where a newline looks like it is ending a statement, but is not.
|
|
* @author Glen Mailer
|
|
* @copyright 2015 Glen Mailer
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
module.exports = function(context) {
|
|
|
|
var FUNCTION_MESSAGE = "Unexpected newline between function and ( of function call.";
|
|
var PROPERTY_MESSAGE = "Unexpected newline between object and [ of property access.";
|
|
var TAGGED_TEMPLATE_MESSAGE = "Unexpected newline between template tag and template literal.";
|
|
|
|
/**
|
|
* Check to see if there is a newline between the node and the following open bracket
|
|
* line's expression
|
|
* @param {ASTNode} node The node to check.
|
|
* @param {string} msg The error message to use.
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function checkForBreakAfter(node, msg) {
|
|
var nodeExpressionEnd = node;
|
|
var openParen = context.getTokenAfter(node);
|
|
|
|
// Move along until the end of the wrapped expression
|
|
while (openParen.value === ")") {
|
|
nodeExpressionEnd = openParen;
|
|
openParen = context.getTokenAfter(nodeExpressionEnd);
|
|
}
|
|
|
|
if (openParen.loc.start.line !== nodeExpressionEnd.loc.end.line) {
|
|
context.report(node, openParen.loc.start, msg, { char: openParen.value });
|
|
}
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public API
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
|
|
"MemberExpression": function(node) {
|
|
if (!node.computed) {
|
|
return;
|
|
}
|
|
checkForBreakAfter(node.object, PROPERTY_MESSAGE);
|
|
},
|
|
|
|
"TaggedTemplateExpression": function(node) {
|
|
if (node.tag.loc.end.line === node.quasi.loc.start.line) {
|
|
return;
|
|
}
|
|
context.report(node, node.loc.start, TAGGED_TEMPLATE_MESSAGE);
|
|
},
|
|
|
|
"CallExpression": function(node) {
|
|
if (node.arguments.length === 0) {
|
|
return;
|
|
}
|
|
checkForBreakAfter(node.callee, FUNCTION_MESSAGE);
|
|
}
|
|
};
|
|
|
|
};
|
|
|
|
module.exports.schema = [];
|