f601d040b5
Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
75 lines
2.3 KiB
JavaScript
75 lines
2.3 KiB
JavaScript
/**
|
|
* @fileoverview A rule to ensure consistent quotes used in jsx syntax.
|
|
* @author Mathias Schreck <https://github.com/lo1tuma>
|
|
* @copyright 2015 Mathias Schreck
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
var astUtils = require("../ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Constants
|
|
//------------------------------------------------------------------------------
|
|
|
|
var QUOTE_SETTINGS = {
|
|
"prefer-double": {
|
|
quote: "\"",
|
|
description: "singlequote",
|
|
convert: function(str) {
|
|
return str.replace(/'/g, "\"");
|
|
}
|
|
},
|
|
"prefer-single": {
|
|
quote: "'",
|
|
description: "doublequote",
|
|
convert: function(str) {
|
|
return str.replace(/"/g, "'");
|
|
}
|
|
}
|
|
};
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
var quoteOption = context.options[0] || "prefer-double",
|
|
setting = QUOTE_SETTINGS[quoteOption];
|
|
|
|
/**
|
|
* Checks if the given string literal node uses the expected quotes
|
|
* @param {ASTNode} node - A string literal node.
|
|
* @returns {boolean} Whether or not the string literal used the expected quotes.
|
|
* @public
|
|
*/
|
|
function usesExpectedQuotes(node) {
|
|
return node.value.indexOf(setting.quote) !== -1 || astUtils.isSurroundedBy(node.raw, setting.quote);
|
|
}
|
|
|
|
return {
|
|
"JSXAttribute": function(node) {
|
|
var attributeValue = node.value;
|
|
|
|
if (attributeValue && astUtils.isStringLiteral(attributeValue) && !usesExpectedQuotes(attributeValue)) {
|
|
context.report({
|
|
node: attributeValue,
|
|
message: "Unexpected usage of " + setting.description + ".",
|
|
fix: function(fixer) {
|
|
return fixer.replaceText(attributeValue, setting.convert(attributeValue.raw));
|
|
}
|
|
});
|
|
}
|
|
}
|
|
};
|
|
};
|
|
|
|
module.exports.schema = [
|
|
{
|
|
"enum": [ "prefer-single", "prefer-double" ]
|
|
}
|
|
];
|