f601d040b5
Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
84 lines
2.3 KiB
JavaScript
84 lines
2.3 KiB
JavaScript
/**
|
|
* @fileoverview Rule to enforce a particular function style
|
|
* @author Nicholas C. Zakas
|
|
* @copyright 2013 Nicholas C. Zakas. All rights reserved.
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
var style = context.options[0],
|
|
allowArrowFunctions = context.options[1] && context.options[1].allowArrowFunctions === true,
|
|
enforceDeclarations = (style === "declaration"),
|
|
stack = [];
|
|
|
|
var nodesToCheck = {
|
|
"Program": function() {
|
|
stack = [];
|
|
},
|
|
|
|
"FunctionDeclaration": function(node) {
|
|
stack.push(false);
|
|
|
|
if (!enforceDeclarations && node.parent.type !== "ExportDefaultDeclaration") {
|
|
context.report(node, "Expected a function expression.");
|
|
}
|
|
},
|
|
"FunctionDeclaration:exit": function() {
|
|
stack.pop();
|
|
},
|
|
|
|
"FunctionExpression": function(node) {
|
|
stack.push(false);
|
|
|
|
if (enforceDeclarations && node.parent.type === "VariableDeclarator") {
|
|
context.report(node.parent, "Expected a function declaration.");
|
|
}
|
|
},
|
|
"FunctionExpression:exit": function() {
|
|
stack.pop();
|
|
},
|
|
|
|
"ThisExpression": function() {
|
|
if (stack.length > 0) {
|
|
stack[stack.length - 1] = true;
|
|
}
|
|
}
|
|
};
|
|
|
|
if (!allowArrowFunctions) {
|
|
nodesToCheck.ArrowFunctionExpression = function() {
|
|
stack.push(false);
|
|
};
|
|
|
|
nodesToCheck["ArrowFunctionExpression:exit"] = function(node) {
|
|
var hasThisExpr = stack.pop();
|
|
|
|
if (enforceDeclarations && !hasThisExpr && node.parent.type === "VariableDeclarator") {
|
|
context.report(node.parent, "Expected a function declaration.");
|
|
}
|
|
};
|
|
}
|
|
|
|
return nodesToCheck;
|
|
|
|
};
|
|
|
|
module.exports.schema = [
|
|
{
|
|
"enum": ["declaration", "expression"]
|
|
},
|
|
{
|
|
"type": "object",
|
|
"properties": {
|
|
"allowArrowFunctions": {
|
|
"type": "boolean"
|
|
}
|
|
},
|
|
"additionalProperties": false
|
|
}
|
|
];
|