d9b8758f47
PR-URL: https://github.com/nodejs/node/pull/6132 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
70 lines
1.9 KiB
JavaScript
70 lines
1.9 KiB
JavaScript
/**
|
|
* @fileoverview require default case in switch statements
|
|
* @author Aliaksei Shytkin
|
|
*/
|
|
"use strict";
|
|
|
|
var COMMENT_VALUE = "no default";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Shortcut to get last element of array
|
|
* @param {*[]} collection Array
|
|
* @returns {*} Last element
|
|
*/
|
|
function last(collection) {
|
|
return collection[collection.length - 1];
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
|
|
"SwitchStatement": function(node) {
|
|
|
|
if (!node.cases.length) {
|
|
|
|
/*
|
|
* skip check of empty switch because there is no easy way
|
|
* to extract comments inside it now
|
|
*/
|
|
return;
|
|
}
|
|
|
|
var hasDefault = node.cases.some(function(v) {
|
|
return v.test === null;
|
|
});
|
|
|
|
if (!hasDefault) {
|
|
|
|
var comment;
|
|
var comments;
|
|
|
|
var lastCase = last(node.cases);
|
|
|
|
comments = context.getComments(lastCase).trailing;
|
|
|
|
if (comments.length) {
|
|
comment = last(comments);
|
|
}
|
|
|
|
if (!comment || comment.value.trim() !== COMMENT_VALUE) {
|
|
context.report(node, "Expected a default case.");
|
|
}
|
|
}
|
|
}
|
|
};
|
|
};
|
|
|
|
module.exports.schema = [];
|