5b42ef5dfe
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: https://github.com/nodejs/node/pull/6205 Fixes: https://github.com/nodejs/node/issues/6201 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
70 lines
1.8 KiB
JavaScript
70 lines
1.8 KiB
JavaScript
'use strict';
|
|
const path = require('path');
|
|
const spawn = require('child_process').spawn;
|
|
const assert = require('assert');
|
|
|
|
const common = require('../common');
|
|
|
|
const fixture = path.join(
|
|
common.fixturesDir,
|
|
'debugger-util-regression-fixture.js'
|
|
);
|
|
|
|
const args = [
|
|
'debug',
|
|
`--port=${common.PORT}`,
|
|
fixture
|
|
];
|
|
|
|
const proc = spawn(process.execPath, args, { stdio: 'pipe' });
|
|
proc.stdout.setEncoding('utf8');
|
|
proc.stderr.setEncoding('utf8');
|
|
|
|
function fail() {
|
|
common.fail('the program should not hang');
|
|
}
|
|
|
|
const timer = setTimeout(fail, common.platformTimeout(4000));
|
|
|
|
let stdout = '';
|
|
let stderr = '';
|
|
|
|
let nextCount = 0;
|
|
|
|
proc.stdout.on('data', (data) => {
|
|
stdout += data;
|
|
if (stdout.includes('> 1') && nextCount < 1 ||
|
|
stdout.includes('> 2') && nextCount < 2 ||
|
|
stdout.includes('> 3') && nextCount < 3 ||
|
|
stdout.includes('> 4') && nextCount < 4) {
|
|
nextCount++;
|
|
proc.stdin.write('n\n');
|
|
}
|
|
else if (stdout.includes('{ a: \'b\' }')) {
|
|
clearTimeout(timer);
|
|
proc.stdin.write('.exit\n');
|
|
}
|
|
else if (stdout.includes('program terminated')) {
|
|
// Catch edge case present in v4.x
|
|
// process will terminate after call to util.inspect
|
|
common.fail('the program should not terminate');
|
|
}
|
|
});
|
|
|
|
proc.stderr.on('data', (data) => stderr += data);
|
|
|
|
// FIXME
|
|
// This test has been periodically failing on certain systems due to
|
|
// uncaught errors on proc.stdin. This will stop the process from
|
|
// exploding but is still not an elegant solution. Likely a deeper bug
|
|
// causing this problem.
|
|
proc.stdin.on('error', (err) => {
|
|
console.error(err);
|
|
});
|
|
|
|
process.on('exit', (code) => {
|
|
assert.equal(code, 0, 'the program should exit cleanly');
|
|
assert.equal(stdout.includes('{ a: \'b\' }'), true,
|
|
'the debugger should print the result of util.inspect');
|
|
assert.equal(stderr, '', 'stderr should be empty');
|
|
});
|