d795301025
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
27 lines
906 B
JavaScript
27 lines
906 B
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
|
|
var vm = require('vm');
|
|
var o = vm.createContext({ console: console });
|
|
|
|
// This triggers the setter callback in node_contextify.cc
|
|
var code = 'var a = function() {};\n';
|
|
|
|
// but this does not, since function decls are defineProperties,
|
|
// not simple sets.
|
|
code += 'function b(){}\n';
|
|
|
|
// Grab the global b function as the completion value, to ensure that
|
|
// we are getting the global function, and not some other thing
|
|
code += '(function(){return this})().b;\n';
|
|
|
|
var res = vm.runInContext(code, o, 'test');
|
|
|
|
assert.equal(typeof res, 'function', 'result should be function');
|
|
assert.equal(res.name, 'b', 'res should be named b');
|
|
assert.equal(typeof o.a, 'function', 'a should be function');
|
|
assert.equal(typeof o.b, 'function', 'b should be function');
|
|
assert.equal(res, o.b, 'result should be global b function');
|
|
|
|
console.log('ok');
|