10d4f470f8
Currently when running configure with the --debug option in combination
with the tests (./configure --debug && make -j8 test) there are a few
addon tests that fail with error messages similar to this:
=== release test ===
Path: addons/load-long-path/test
fs.js:558
return binding.open(pathModule._makeLong(path), stringToFlags(flags),
mode);
^
Error: ENOENT: no such file or directory, open
'/nodejs/node/test/addons/load-long-path/build/Release/binding.node'
at Object.fs.openSync (fs.js:558:18)
at Object.fs.readFileSync (fs.js:468:33)
at Object.<anonymous>
(/nodejs/node/test/addons/load-long-path/test.js:28:19)
at Module._compile (module.js:560:32)
at Object.Module._extensions..js (module.js:569:10)
at Module.load (module.js:477:32)
at tryModuleLoad (module.js:436:12)
at Function.Module._load (module.js:428:3)
at Module.runMain (module.js:594:10)
at run (bootstrap_node.js:382:7)
Command: out/Release/node
/nodejs/node/test/addons/load-long-path/test.js
This commit allows for the tests to pass even if the configured build
type is of type debug.
PR-URL: https://github.com/nodejs/node/pull/8836
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
61 lines
1.6 KiB
JavaScript
61 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
const binding = require(`./build/${common.buildType}/binding`);
|
|
const makeCallback = binding.makeCallback;
|
|
|
|
assert.strictEqual(42, makeCallback(process, common.mustCall(function() {
|
|
assert.strictEqual(0, arguments.length);
|
|
assert.strictEqual(this, process);
|
|
return 42;
|
|
})));
|
|
|
|
assert.strictEqual(42, makeCallback(process, common.mustCall(function(x) {
|
|
assert.strictEqual(1, arguments.length);
|
|
assert.strictEqual(this, process);
|
|
assert.strictEqual(x, 1337);
|
|
return 42;
|
|
}), 1337));
|
|
|
|
const recv = {
|
|
one: common.mustCall(function() {
|
|
assert.strictEqual(0, arguments.length);
|
|
assert.strictEqual(this, recv);
|
|
return 42;
|
|
}),
|
|
two: common.mustCall(function(x) {
|
|
assert.strictEqual(1, arguments.length);
|
|
assert.strictEqual(this, recv);
|
|
assert.strictEqual(x, 1337);
|
|
return 42;
|
|
}),
|
|
};
|
|
|
|
assert.strictEqual(42, makeCallback(recv, 'one'));
|
|
assert.strictEqual(42, makeCallback(recv, 'two', 1337));
|
|
|
|
// Check that the callback is made in the context of the receiver.
|
|
const target = vm.runInNewContext(`
|
|
(function($Object) {
|
|
if (Object === $Object)
|
|
throw new Error('bad');
|
|
return Object;
|
|
})
|
|
`);
|
|
assert.notStrictEqual(Object, makeCallback(process, target, Object));
|
|
|
|
// Runs in inner context.
|
|
const forward = vm.runInNewContext(`
|
|
(function(forward) {
|
|
return forward(Object);
|
|
})
|
|
`);
|
|
// Runs in outer context.
|
|
const endpoint = function($Object) {
|
|
if (Object === $Object)
|
|
throw new Error('bad');
|
|
return Object;
|
|
};
|
|
assert.strictEqual(Object, makeCallback(process, forward, endpoint));
|