9c3e246ffeOriginal commit message:
Timezone name check fix
1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
didn't work because of the way capturing works with repeated patterns
in RE. It's now supported by changing the RE to capture the whole string
and splitting on '_' in the next step.
2. Adds support for location names with a hyphen
3. Adds support for timezone ids with three parts (e.g.
American/Argentina/Buenos_Aires)
4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be kept in lowercase. (see the full list at https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )
5. Adds regression tests for all the above and make the existing tests
more robust against future ICU changes. ICU canonicalizes zone names to
deprecated names, but it may change. (
http://bugs.icu-project.org/trac/ticket/12044 )
BUG=364374
LOG=Y
Review URL: https://codereview.chromium.org/1529363005
Cr-Commit-Position: refs/heads/master@{#33097}
PR-URL: https://github.com/nodejs/node/pull/15562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
20 lines
772 B
C
20 lines
772 B
C
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_INCLUDE_VERSION_H_ // V8_VERSION_H_ conflicts with src/version.h
|
|
#define V8_INCLUDE_VERSION_H_
|
|
|
|
// These macros define the version number for the current version.
|
|
// NOTE these macros are used by some of the tool scripts and the build
|
|
// system so their names cannot be changed without changing the scripts.
|
|
#define V8_MAJOR_VERSION 4
|
|
#define V8_MINOR_VERSION 5
|
|
#define V8_BUILD_NUMBER 103
|
|
#define V8_PATCH_LEVEL 53
|
|
|
|
// Use 1 for candidates and 0 otherwise.
|
|
// (Boolean macro values are not supported by all preprocessors.)
|
|
#define V8_IS_CANDIDATE_VERSION 0
|
|
|
|
#endif // V8_INCLUDE_VERSION_H_
|