51ced0f1a1In #39175, better ESM errors were introduced. This commit tweaks the language in the error slightly to make it clear that there are three different options to resolve the error. Refs: https://github.com/nodejs/node/pull/39175 PR-URL: https://github.com/nodejs/node/pull/49521 Backport-PR-URL: https://github.com/nodejs/node/pull/50669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
68 lines
2.2 KiB
JavaScript
68 lines
2.2 KiB
JavaScript
'use strict';
|
|
|
|
const { spawnPromisified } = require('../common');
|
|
const fixtures = require('../common/fixtures.js');
|
|
const assert = require('node:assert');
|
|
const path = require('node:path');
|
|
const { execPath } = require('node:process');
|
|
const { describe, it } = require('node:test');
|
|
|
|
|
|
const requiringCjsAsEsm = path.resolve(fixtures.path('/es-modules/cjs-esm.js'));
|
|
const requiringEsm = path.resolve(fixtures.path('/es-modules/cjs-esm-esm.js'));
|
|
const pjson = path.resolve(
|
|
fixtures.path('/es-modules/package-type-module/package.json')
|
|
);
|
|
|
|
|
|
describe('CJS ↔︎ ESM interop warnings', { concurrency: true }, () => {
|
|
|
|
it(async () => {
|
|
const required = path.resolve(
|
|
fixtures.path('/es-modules/package-type-module/cjs.js')
|
|
);
|
|
const basename = 'cjs.js';
|
|
const { code, signal, stderr } = await spawnPromisified(execPath, [requiringCjsAsEsm]);
|
|
|
|
assert.ok(
|
|
stderr.replaceAll('\r', '').includes(
|
|
`Error [ERR_REQUIRE_ESM]: require() of ES Module ${required} from ${requiringCjsAsEsm} not supported.\n`
|
|
)
|
|
);
|
|
assert.ok(
|
|
stderr.replaceAll('\r', '').includes(
|
|
`Instead either rename ${basename} to end in .cjs, change the requiring ` +
|
|
'code to use dynamic import() which is available in all CommonJS ' +
|
|
`modules, or change "type": "module" to "type": "commonjs" in ${pjson} to ` +
|
|
'treat all .js files as CommonJS (using .mjs for all ES modules ' +
|
|
'instead).\n'
|
|
)
|
|
);
|
|
|
|
assert.strictEqual(code, 1);
|
|
assert.strictEqual(signal, null);
|
|
});
|
|
|
|
it(async () => {
|
|
const required = path.resolve(
|
|
fixtures.path('/es-modules/package-type-module/esm.js')
|
|
);
|
|
const basename = 'esm.js';
|
|
const { code, signal, stderr } = await spawnPromisified(execPath, [requiringEsm]);
|
|
|
|
assert.ok(
|
|
stderr.replace(/\r/g, '').includes(
|
|
`Error [ERR_REQUIRE_ESM]: require() of ES Module ${required} from ${requiringEsm} not supported.\n`
|
|
)
|
|
);
|
|
assert.ok(
|
|
stderr.replace(/\r/g, '').includes(
|
|
`Instead change the require of ${basename} in ${requiringEsm} to` +
|
|
' a dynamic import() which is available in all CommonJS modules.\n'
|
|
)
|
|
);
|
|
|
|
assert.strictEqual(code, 1);
|
|
assert.strictEqual(signal, null);
|
|
});
|
|
});
|