53b12c3731Currently there are a number of compiler warnings like the following:
../binding.cc:6:41:
warning: 'NewFromUtf8' is deprecated:
Use maybe version [-Wdeprecated-declarations]
args.GetReturnValue().Set(v8::String::NewFromUtf8(isolate, "world"));
^
/node/deps/v8/include/v8.h:2883:10:
note: 'NewFromUtf8' has been explicitly marked deprecated here
static V8_DEPRECATE_SOON(
^
/node/deps/v8/include/v8config.h:341:29:
note: expanded from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
This commit updates the code to use the maybe versions.
PR-URL: https://github.com/nodejs/node/pull/24216
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
35 lines
1.2 KiB
C++
35 lines
1.2 KiB
C++
#include <node.h>
|
|
#include <assert.h>
|
|
#include <openssl/rand.h>
|
|
|
|
namespace {
|
|
|
|
inline void RandomBytes(const v8::FunctionCallbackInfo<v8::Value>& info) {
|
|
assert(info[0]->IsArrayBufferView());
|
|
auto view = info[0].As<v8::ArrayBufferView>();
|
|
auto byte_offset = view->ByteOffset();
|
|
auto byte_length = view->ByteLength();
|
|
assert(view->HasBuffer());
|
|
auto buffer = view->Buffer();
|
|
auto contents = buffer->GetContents();
|
|
auto data = static_cast<unsigned char*>(contents.Data()) + byte_offset;
|
|
assert(RAND_poll());
|
|
auto rval = RAND_bytes(data, static_cast<int>(byte_length));
|
|
info.GetReturnValue().Set(rval > 0);
|
|
}
|
|
|
|
inline void Initialize(v8::Local<v8::Object> exports,
|
|
v8::Local<v8::Value> module,
|
|
v8::Local<v8::Context> context) {
|
|
auto isolate = context->GetIsolate();
|
|
auto key = v8::String::NewFromUtf8(
|
|
isolate, "randomBytes", v8::NewStringType::kNormal).ToLocalChecked();
|
|
auto value = v8::FunctionTemplate::New(isolate, RandomBytes)
|
|
->GetFunction(context)
|
|
.ToLocalChecked();
|
|
assert(exports->Set(context, key, value).IsJust());
|
|
}
|
|
|
|
} // anonymous namespace
|
|
|
|
NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
|