At the uv layer pipes are connected with uv_pipe_connect. The current spec for this method indicates that the maximum length is limited to the size of length of sizeof(sockaddr_un.sun_path), typically between 92 and 108 bytes. Anything longer than that just gets truncated. The simple testsuite currently creates pipes in directories under the directory where node was built. In our jenkins jobs this sometimes ends up being a deep enough path that the path for the pipes is getting truncated. The result is that tests using pipes fail with errors that don't make it obvious what the problem is. Even if the errors were helpful, we still need a way to avoid the truncation. This patch adds the environment variable NODE_PIPE_DIR. If set the tests create pipes in this directory instead of the current defaults. In addition the test harness is updated to remove/delete this directory before/after each test is run. modified: test/common.js modified: test/simple/test-net-pipe-connect-errors.js modified: test/testpy/__init__.py modified: test/simple/test-cluster-eaccess.js Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/9381
171 lines
5.6 KiB
Python
171 lines
5.6 KiB
Python
# Copyright 2008 the V8 project authors. All rights reserved.
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above
|
|
# copyright notice, this list of conditions and the following
|
|
# disclaimer in the documentation and/or other materials provided
|
|
# with the distribution.
|
|
# * Neither the name of Google Inc. nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import test
|
|
import os
|
|
import shutil
|
|
from shutil import rmtree
|
|
from os import mkdir
|
|
from glob import glob
|
|
from os.path import join, dirname, exists
|
|
import re
|
|
|
|
|
|
FLAGS_PATTERN = re.compile(r"//\s+Flags:(.*)")
|
|
FILES_PATTERN = re.compile(r"//\s+Files:(.*)")
|
|
|
|
|
|
class SimpleTestCase(test.TestCase):
|
|
|
|
def __init__(self, path, file, mode, context, config, additional=[]):
|
|
super(SimpleTestCase, self).__init__(context, path, mode)
|
|
self.file = file
|
|
self.config = config
|
|
self.mode = mode
|
|
self.tmpdir = join(dirname(self.config.root), 'tmp')
|
|
self.additional_flags = additional
|
|
if "NODE_PIPE_DIR" in os.environ:
|
|
self.pipeTmpDir = join(os.environ["NODE_PIPE_DIR"], 'NodePipeTmp')
|
|
|
|
def AfterRun(self, result):
|
|
# delete the whole tmp dir
|
|
try:
|
|
rmtree(self.tmpdir)
|
|
if self.pipeTmpDir:
|
|
rmtree(self.pipeTmpDir);
|
|
except:
|
|
pass
|
|
# make it again.
|
|
try:
|
|
mkdir(self.tmpdir)
|
|
if self.pipeTmpDir:
|
|
mkdir(self.pipeTmpDir);
|
|
except:
|
|
pass
|
|
|
|
def BeforeRun(self):
|
|
# delete the whole tmp dir
|
|
try:
|
|
rmtree(self.tmpdir)
|
|
if self.pipeTmpDir:
|
|
rmtree(self.pipeTmpDir);
|
|
except:
|
|
pass
|
|
# make it again.
|
|
# intermittently fails on win32, so keep trying
|
|
while not os.path.exists(self.tmpdir):
|
|
try:
|
|
mkdir(self.tmpdir)
|
|
if self.pipeTmpDir:
|
|
mkdir(self.pipeTmpDir);
|
|
except:
|
|
pass
|
|
|
|
def GetLabel(self):
|
|
return "%s %s" % (self.mode, self.GetName())
|
|
|
|
def GetName(self):
|
|
return self.path[-1]
|
|
|
|
def GetCommand(self):
|
|
result = [self.config.context.GetVm(self.mode)]
|
|
source = open(self.file).read()
|
|
flags_match = FLAGS_PATTERN.search(source)
|
|
if flags_match:
|
|
result += flags_match.group(1).strip().split()
|
|
files_match = FILES_PATTERN.search(source);
|
|
additional_files = []
|
|
if files_match:
|
|
additional_files += files_match.group(1).strip().split()
|
|
for a_file in additional_files:
|
|
result.append(join(dirname(self.config.root), '..', a_file))
|
|
|
|
if self.additional_flags:
|
|
result += self.additional_flags
|
|
|
|
result += [self.file]
|
|
|
|
return result
|
|
|
|
def GetSource(self):
|
|
return open(self.file).read()
|
|
|
|
|
|
class SimpleTestConfiguration(test.TestConfiguration):
|
|
|
|
def __init__(self, context, root, section, additional=[]):
|
|
super(SimpleTestConfiguration, self).__init__(context, root)
|
|
self.section = section
|
|
self.additional_flags = additional
|
|
|
|
def Ls(self, path):
|
|
def SelectTest(name):
|
|
return name.startswith('test-') and name.endswith('.js')
|
|
return [f[:-3] for f in os.listdir(path) if SelectTest(f)]
|
|
|
|
def ListTests(self, current_path, path, mode):
|
|
all_tests = [current_path + [t] for t in self.Ls(join(self.root))]
|
|
result = []
|
|
for test in all_tests:
|
|
if self.Contains(path, test):
|
|
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
|
|
result.append(SimpleTestCase(test, file_path, mode, self.context, self,
|
|
self.additional_flags))
|
|
return result
|
|
|
|
def GetBuildRequirements(self):
|
|
return ['sample', 'sample=shell']
|
|
|
|
def GetTestStatus(self, sections, defs):
|
|
status_file = join(self.root, '%s.status' % (self.section))
|
|
if exists(status_file):
|
|
test.ReadConfigurationInto(status_file, sections, defs)
|
|
|
|
class AddonTestConfiguration(SimpleTestConfiguration):
|
|
def __init__(self, context, root, section, additional=[]):
|
|
super(AddonTestConfiguration, self).__init__(context, root, section)
|
|
|
|
def Ls(self, path):
|
|
def SelectTest(name):
|
|
return name.endswith('.js')
|
|
|
|
result = []
|
|
for subpath in os.listdir(path):
|
|
if os.path.isdir(join(path, subpath)):
|
|
for f in os.listdir(join(path, subpath)):
|
|
if SelectTest(f):
|
|
result.append([subpath, f[:-3]])
|
|
return result
|
|
|
|
def ListTests(self, current_path, path, mode):
|
|
all_tests = [current_path + t for t in self.Ls(join(self.root))]
|
|
result = []
|
|
for test in all_tests:
|
|
if self.Contains(path, test):
|
|
file_path = join(self.root, reduce(join, test[1:], "") + ".js")
|
|
result.append(SimpleTestCase(test, file_path, mode, self.context, self))
|
|
return result
|