36bcfa7913PR-URL: https://github.com/nodejs/node/pull/63857 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
123 lines
3.1 KiB
JavaScript
123 lines
3.1 KiB
JavaScript
const t = require('tap')
|
|
const path = require('node:path')
|
|
const fs = require('node:fs')
|
|
|
|
const { load: loadMockNpm } = require('../../fixtures/mock-npm')
|
|
const MockRegistry = require('@npmcli/mock-registry')
|
|
|
|
t.test('should throw in global mode', async (t) => {
|
|
const { npm } = await loadMockNpm(t, {
|
|
config: {
|
|
global: true,
|
|
},
|
|
})
|
|
t.rejects(
|
|
npm.exec('dedupe', []),
|
|
{ code: 'EDEDUPEGLOBAL' },
|
|
'throws EDEDUPEGLOBALE'
|
|
)
|
|
})
|
|
|
|
const treeWithDupes = {
|
|
'package.json': JSON.stringify({
|
|
name: 'test-top',
|
|
version: '1.0.0',
|
|
dependencies: {
|
|
'test-dep-a': '*',
|
|
'test-dep-b': '*',
|
|
},
|
|
}),
|
|
node_modules: {
|
|
'test-dep-a': {
|
|
'package.json': JSON.stringify({
|
|
name: 'test-dep-a',
|
|
version: '1.0.1',
|
|
dependencies: { 'test-sub': '*' },
|
|
}),
|
|
node_modules: {
|
|
'test-sub': {
|
|
'package.json': JSON.stringify({
|
|
name: 'test-sub',
|
|
version: '1.0.0',
|
|
}),
|
|
},
|
|
},
|
|
},
|
|
'test-dep-b': {
|
|
'package.json': JSON.stringify({
|
|
name: 'test-dep-b',
|
|
version: '1.0.0',
|
|
dependencies: { 'test-sub': '*' },
|
|
}),
|
|
node_modules: {
|
|
'test-sub': {
|
|
'package.json': JSON.stringify({
|
|
name: 'test-sub',
|
|
version: '1.0.0',
|
|
}),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
t.test('dedupe', async (t) => {
|
|
const { npm, joinedOutput } = await loadMockNpm(t, {
|
|
prefixDir: treeWithDupes,
|
|
})
|
|
const registry = new MockRegistry({
|
|
tap: t,
|
|
registry: npm.config.get('registry'),
|
|
})
|
|
const manifestSub = registry.manifest({
|
|
name: 'test-sub',
|
|
packuments: [{ version: '1.0.0' }],
|
|
})
|
|
|
|
await registry.package({
|
|
manifest: manifestSub,
|
|
tarballs: {
|
|
'1.0.0': path.join(npm.prefix, 'node_modules', 'test-dep-a', 'node_modules', 'test-sub'),
|
|
},
|
|
})
|
|
await npm.exec('dedupe', [])
|
|
t.match(joinedOutput(), /added 1 package, and removed 2 packages/)
|
|
t.ok(
|
|
fs.existsSync(path.join(npm.prefix, 'node_modules', 'test-sub')),
|
|
'test-sub was hoisted'
|
|
)
|
|
t.notOk(
|
|
fs.existsSync(path.join(npm.prefix, 'node_modules', 'test-dep-a', 'node_modules', 'test-sub')),
|
|
'test-dep-a/test-sub was removed'
|
|
)
|
|
t.notOk(
|
|
fs.existsSync(path.join(npm.prefix, 'node_modules', 'test-dep-b', 'node_modules', 'test-sub')),
|
|
'test-dep-b/test-sub was removed')
|
|
})
|
|
|
|
t.test('dedupe threads allowScripts policy through to arborist', async t => {
|
|
let capturedOpts
|
|
const FakeArborist = function (opts) {
|
|
capturedOpts = opts
|
|
this.options = opts
|
|
this.actualTree = { inventory: new Map() }
|
|
}
|
|
FakeArborist.prototype.dedupe = async () => {}
|
|
|
|
const { npm } = await loadMockNpm(t, {
|
|
prefixDir: {
|
|
'package.json': JSON.stringify({
|
|
name: 'host',
|
|
version: '1.0.0',
|
|
allowScripts: { canvas: true },
|
|
}),
|
|
},
|
|
mocks: {
|
|
'@npmcli/arborist': FakeArborist,
|
|
'{LIB}/utils/reify-finish.js': async () => {},
|
|
},
|
|
})
|
|
await npm.exec('dedupe', [])
|
|
t.strictSame(capturedOpts.allowScripts, { canvas: true },
|
|
'opts.allowScripts populated from package.json')
|
|
})
|