756a24242e
/usr/lib/libm.tbd is available via libSystem.*.dylib and
reexports sanitizer symbols. When building for asan
this becomes an issue as the linker will resolve the symbols
from the system library rather from libclang_rt.*
For V8 that rely on specific version of these symbols
that get bundled as part of clang, for ex:
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/cppgc/platform.cc;l=93-97
accepting nullptr for shadow_offset in `asan_get_shadow_mapping`,
linking to system version that doesn't support this will lead to
a crash.
Clang driver eventually links with `-lSystem`
e82f93890d/clang/lib/Driver/ToolChains/Darwin.cpp (L1628-L1631),
this is done after linking the sanitizer libraries which
ensures right order of resolution for the symbols.
PR-URL: https://github.com/nodejs/node/pull/56901
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
39 lines
1.1 KiB
Text
39 lines
1.1 KiB
Text
# This file is used by GN for building, which is NOT the build system used for
|
|
# building official binaries.
|
|
# Please edit the gyp files if you are making changes to build system.
|
|
|
|
# The actual configurations are put inside a template in unofficial.gni to
|
|
# prevent accidental edits from contributors.
|
|
template("brotli_gn_build") {
|
|
config("brotli_config") {
|
|
include_dirs = [ "c/include" ]
|
|
}
|
|
|
|
gypi_values = exec_script("../../tools/gypi_to_gn.py",
|
|
[ rebase_path("brotli.gyp") ],
|
|
"scope",
|
|
[ "brotli.gyp" ])
|
|
|
|
source_set(target_name) {
|
|
forward_variables_from(invoker, "*")
|
|
public_configs = [ ":brotli_config" ]
|
|
sources = gypi_values.brotli_sources
|
|
if (is_linux) {
|
|
defines = [ "OS_LINUX" ]
|
|
} else if (is_mac) {
|
|
defines = [ "OS_MACOSX" ]
|
|
} else if (target_os == "freebsd") {
|
|
defines = [ "OS_FREEBSD" ]
|
|
}
|
|
if (is_linux) {
|
|
libs = [ "m" ]
|
|
}
|
|
if (is_clang || !is_win) {
|
|
cflags_c = [
|
|
"-Wno-implicit-fallthrough",
|
|
"-Wno-unreachable-code",
|
|
"-Wno-unreachable-code-return",
|
|
]
|
|
}
|
|
}
|
|
}
|