ff101999edRework lib/internal/webidl.js into a documented shared converter module that follows the Web IDL conversion algorithms more closely. Improvements: - Add documented converters and helper factories for primitive values, dictionaries, enums, sequences, interfaces, required arguments, integers, `Uint8Array`, and `BufferSource`. - Move WebCrypto onto the shared converters, while keeping compatibility wrappers for its existing `BufferSource` and `BigInteger` behavior. - Use shared converters from Blob, Performance, Web Locks, and structured clone option handling. - Add benchmarks for `ConvertToInt` and WebCrypto Web IDL converter hot paths. - Add focused tests for core converters, WebCrypto converters, integer conversion, and buffer source behavior. Fixes: - Make the shared `BufferSource` and `Uint8Array` converters reject resizable `ArrayBuffer` and growable `SharedArrayBuffer` backing stores unless explicitly allowed. WebCrypto preserves its legacy resizable backing-store behavior through compatibility wrappers until a semver-major follow-up can opt in to the stricter behavior. - Use Web IDL `ToNumber` and `ToString` behavior for BigInt, Symbol, and object primitive conversion. - Use exact BigInt modulo for 64-bit `ConvertToInt` wrapping and document the final Number approximation behavior. - Normalize mathematical modulo results to `+0` where Web IDL requires it. - Process inherited dictionaries in least-derived to most-derived order, sorting members only within each dictionary level. - Use `IteratorComplete` truthiness for sequence conversion. - Cover detached buffers, resizable-backed views, growable-backed views, cross-realm buffer sources, mutation-after-call behavior, inherited dictionary member order, and sequence iterator completion behavior. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62979 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
109 lines
3.5 KiB
JavaScript
109 lines
3.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common.js');
|
|
|
|
const bench = common.createBenchmark(main, {
|
|
op: [
|
|
'normalizeAlgorithm-string',
|
|
'normalizeAlgorithm-dict',
|
|
'webidl-dict',
|
|
'webidl-algorithm-identifier-string',
|
|
'webidl-algorithm-identifier-object',
|
|
'webidl-dict-enforce-range',
|
|
'webidl-dict-ensure-sha',
|
|
'webidl-dict-null',
|
|
],
|
|
n: [1e6],
|
|
}, { flags: ['--expose-internals'] });
|
|
|
|
function main({ n, op }) {
|
|
const { normalizeAlgorithm } = require('internal/crypto/util');
|
|
|
|
switch (op) {
|
|
case 'normalizeAlgorithm-string': {
|
|
// String shortcut + null dictionary (cheapest path).
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
normalizeAlgorithm('SHA-256', 'digest');
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
case 'normalizeAlgorithm-dict': {
|
|
// Object input with a dictionary type and no BufferSource members.
|
|
const alg = { name: 'ECDSA', hash: 'SHA-256' };
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
normalizeAlgorithm(alg, 'sign');
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
case 'webidl-dict': {
|
|
// WebIDL dictionary converter in isolation.
|
|
const webidl = require('internal/crypto/webidl');
|
|
const input = { name: 'AES-GCM', iv: new Uint8Array(12) };
|
|
const opts = { prefix: 'test', context: 'test' };
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
webidl.converters.AeadParams(input, opts);
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
case 'webidl-algorithm-identifier-string': {
|
|
// Exercises converters.AlgorithmIdentifier string path.
|
|
const webidl = require('internal/crypto/webidl');
|
|
const opts = { prefix: 'test', context: 'test' };
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
webidl.converters.AlgorithmIdentifier('SHA-256', opts);
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
case 'webidl-algorithm-identifier-object': {
|
|
// Exercises converters.AlgorithmIdentifier object path.
|
|
const webidl = require('internal/crypto/webidl');
|
|
const input = { name: 'SHA-256' };
|
|
const opts = { prefix: 'test', context: 'test' };
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
webidl.converters.AlgorithmIdentifier(input, opts);
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
case 'webidl-dict-enforce-range': {
|
|
// Exercises [EnforceRange] integer dictionary members.
|
|
const webidl = require('internal/crypto/webidl');
|
|
const input = {
|
|
name: 'RSASSA-PKCS1-v1_5',
|
|
modulusLength: 2048,
|
|
publicExponent: new Uint8Array([1, 0, 1]),
|
|
};
|
|
const opts = { prefix: 'test', context: 'test' };
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
webidl.converters.RsaKeyGenParams(input, opts);
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
case 'webidl-dict-ensure-sha': {
|
|
// Exercises ensureSHA on a hash member.
|
|
const webidl = require('internal/crypto/webidl');
|
|
const input = { name: 'RSASSA-PKCS1-v1_5', hash: 'SHA-256' };
|
|
const opts = { prefix: 'test', context: 'test' };
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
webidl.converters.RsaHashedImportParams(input, opts);
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
case 'webidl-dict-null': {
|
|
// Exercises the null/undefined path in createDictionaryConverter().
|
|
const webidl = require('internal/crypto/webidl');
|
|
const opts = { prefix: 'test', context: 'test' };
|
|
bench.start();
|
|
for (let i = 0; i < n; i++)
|
|
webidl.converters.JsonWebKey(undefined, opts);
|
|
bench.end(n);
|
|
break;
|
|
}
|
|
}
|
|
}
|