1ad06ff9a7
Adds an ArrayBuffer-based invocation path for FFI functions whose signatures are composed entirely of numeric types (i8..i64, u8..u64, f32, f64, bool, char) and/or pointer types. The JS wrapper packs arguments directly into a per-function AB via primordial DataView setters and the C++ invoker (`InvokeFunctionSB`) reads them without going through V8's `FunctionCallbackInfo`. Results are returned the same way. Pointer arguments use runtime dispatch: BigInt, null, and undefined take the fast path, while Buffer, ArrayBuffer, ArrayBufferView, and String fall back transparently to the classic `InvokeFunction` path via a stashed `_invokeSlow` function. Signatures containing non-numeric/non-pointer types also bypass the fast path. The fast path is disabled on big-endian platforms. Callers do not opt in, and the fast path is transparent in every way users should rely on. One observable change: function wrappers returned by `library.getFunction`, `library.getFunctions`, and `library.functions` now have `.length` equal to the declared parameter count rather than `0`. Code that relied on the previous value will need to be updated. Adds microbenchmarks covering the common FFI call shapes so future changes to the invoker can be evaluated: - add-i32.js: 2-arg integer - add-f64.js: 2-arg float - many-args.js: 6-arg integer - pointer-bigint.js: 1-arg pointer (BigInt) - sum-buffer.js: pointer + length (Buffer) A `common.js` helper resolves the fixture-library path from `test/ffi/fixture_library` without pulling in the test harness, and throws a clear message if the fixture hasn't been built yet. Also adds `sum_6_i32` to the fixture library for the many-args case. Signed-off-by: Bryan English <bryan@bryanenglish.com> PR-URL: https://github.com/nodejs/node/pull/62918 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
24 lines
926 B
JavaScript
24 lines
926 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common.js');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
// Cannot use test/ffi/ffi-test-common.js because it requires test/common
|
|
// (the test harness module). Construct the path directly.
|
|
const libraryPath = path.join(__dirname, '..', '..', 'test', 'ffi',
|
|
'fixture_library', 'build', common.buildType,
|
|
process.platform === 'win32' ? 'ffi_test_library.dll' :
|
|
process.platform === 'darwin' ? 'ffi_test_library.dylib' :
|
|
'ffi_test_library.so');
|
|
|
|
function ensureFixtureLibrary() {
|
|
if (!fs.existsSync(libraryPath)) {
|
|
throw new Error(
|
|
`Missing FFI fixture library: ${libraryPath}. ` +
|
|
'Build it with `tools/test.py test/ffi/test-ffi-calls.js` first.',
|
|
);
|
|
}
|
|
}
|
|
|
|
module.exports = { libraryPath, ensureFixtureLibrary };
|