The snapshotted stack frames should hide node internal stack frames so that general node core development does not need updating the snapshot. For userland stack frames, they are highly fixture related and any fixture change should reflect in a change of the snapshot. Additionally, the line and column number are highly relevant to the correctness of the snapshot, these should not be redacted. A change in node core that affects userland stack frames should be alarming and be reflected in the snapshots. Features like test runner and source map support both should snapshot userland stack frames to ensure that userland code locations are computed correctly. PR-URL: https://github.com/nodejs/node/pull/61665 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
95 lines
2.9 KiB
Text
95 lines
2.9 KiB
Text
TAP version 13
|
|
# Subtest: planning with wait
|
|
# Subtest: planning with wait and passing
|
|
ok 1 - planning with wait and passing
|
|
---
|
|
duration_ms: *
|
|
type: 'test'
|
|
...
|
|
# Subtest: planning with wait and failing
|
|
not ok 2 - planning with wait and failing
|
|
---
|
|
duration_ms: *
|
|
type: 'test'
|
|
location: '<project-root>/test/fixtures/test-runner/output/test-runner-plan-timeout.js:17:3'
|
|
failureType: 'uncaughtException'
|
|
error: |-
|
|
The expression evaluated to a falsy value:
|
|
|
|
t.assert.ok(false)
|
|
|
|
code: 'ERR_ASSERTION'
|
|
name: 'AssertionError'
|
|
expected: true
|
|
actual: false
|
|
operator: '=='
|
|
stack: |-
|
|
Timeout._onTimeout (<project-root>/test/fixtures/test-runner/output/test-runner-plan-timeout.js:22:18)
|
|
<node-internal-frames>
|
|
...
|
|
# Subtest: planning wait time expires before plan is met
|
|
not ok 3 - planning wait time expires before plan is met
|
|
---
|
|
duration_ms: *
|
|
type: 'test'
|
|
location: '<project-root>/test/fixtures/test-runner/output/test-runner-plan-timeout.js:29:3'
|
|
failureType: 'testTimeoutFailure'
|
|
error: 'plan timed out after 500ms with 0 assertions when expecting 2'
|
|
code: 'ERR_TEST_FAILURE'
|
|
...
|
|
# Subtest: planning with wait "options.wait : true" and passing
|
|
ok 4 - planning with wait "options.wait : true" and passing
|
|
---
|
|
duration_ms: *
|
|
type: 'test'
|
|
...
|
|
# Subtest: planning with wait "options.wait : true" and failing
|
|
not ok 5 - planning with wait "options.wait : true" and failing
|
|
---
|
|
duration_ms: *
|
|
type: 'test'
|
|
location: '<project-root>/test/fixtures/test-runner/output/test-runner-plan-timeout.js:53:3'
|
|
failureType: 'uncaughtException'
|
|
error: |-
|
|
The expression evaluated to a falsy value:
|
|
|
|
t.assert.ok(false)
|
|
|
|
code: 'ERR_ASSERTION'
|
|
name: 'AssertionError'
|
|
expected: true
|
|
actual: false
|
|
operator: '=='
|
|
stack: |-
|
|
Timeout._onTimeout (<project-root>/test/fixtures/test-runner/output/test-runner-plan-timeout.js:58:18)
|
|
<node-internal-frames>
|
|
...
|
|
# Subtest: planning with wait "options.wait : false" should not wait
|
|
not ok 6 - planning with wait "options.wait : false" should not wait
|
|
---
|
|
duration_ms: *
|
|
type: 'test'
|
|
location: '<project-root>/test/fixtures/test-runner/output/test-runner-plan-timeout.js:65:3'
|
|
failureType: 'testCodeFailure'
|
|
error: 'plan expected 1 assertions but received 0'
|
|
code: 'ERR_TEST_FAILURE'
|
|
...
|
|
1..6
|
|
not ok 1 - planning with wait
|
|
---
|
|
duration_ms: *
|
|
type: 'suite'
|
|
location: '<project-root>/test/fixtures/test-runner/output/test-runner-plan-timeout.js:4:1'
|
|
failureType: 'subtestsFailed'
|
|
error: '4 subtests failed'
|
|
code: 'ERR_TEST_FAILURE'
|
|
...
|
|
1..1
|
|
# tests 6
|
|
# suites 1
|
|
# pass 2
|
|
# fail 3
|
|
# cancelled 1
|
|
# skipped 0
|
|
# todo 0
|
|
# duration_ms *
|