fa70327610Make localStorage return undefined and emit a warning when
--localstorage-file is not provided. Mark the property as
non-enumerable to avoid breaking {...globalThis}.
Fixes: https://github.com/nodejs/node/issues/60303
PR-URL: https://github.com/nodejs/node/pull/61333
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
57 lines
1.6 KiB
JavaScript
57 lines
1.6 KiB
JavaScript
'use strict';
|
|
const {
|
|
ObjectDefineProperties,
|
|
} = primordials;
|
|
const { getOptionValue } = require('internal/options');
|
|
const { kConstructorKey, Storage } = internalBinding('webstorage');
|
|
const { getValidatedPath } = require('internal/fs/utils');
|
|
const kInMemoryPath = ':memory:';
|
|
|
|
module.exports = { Storage };
|
|
|
|
let lazyLocalStorage;
|
|
let lazySessionStorage;
|
|
let localStorageWarned = false;
|
|
|
|
// Check at load time if localStorage file is provided to determine enumerability.
|
|
// If not provided, localStorage is non-enumerable to avoid breaking {...globalThis}.
|
|
const localStorageLocation = getOptionValue('--localstorage-file');
|
|
|
|
ObjectDefineProperties(module.exports, {
|
|
__proto__: null,
|
|
localStorage: {
|
|
__proto__: null,
|
|
configurable: true,
|
|
enumerable: localStorageLocation !== '',
|
|
get() {
|
|
if (lazyLocalStorage === undefined) {
|
|
if (localStorageLocation === '') {
|
|
if (!localStorageWarned) {
|
|
localStorageWarned = true;
|
|
process.emitWarning(
|
|
'localStorage is not available because --localstorage-file was not provided.',
|
|
'ExperimentalWarning',
|
|
);
|
|
}
|
|
return undefined;
|
|
}
|
|
|
|
lazyLocalStorage = new Storage(kConstructorKey, getValidatedPath(localStorageLocation));
|
|
}
|
|
|
|
return lazyLocalStorage;
|
|
},
|
|
},
|
|
sessionStorage: {
|
|
__proto__: null,
|
|
configurable: true,
|
|
enumerable: true,
|
|
get() {
|
|
if (lazySessionStorage === undefined) {
|
|
lazySessionStorage = new Storage(kConstructorKey, kInMemoryPath);
|
|
}
|
|
|
|
return lazySessionStorage;
|
|
},
|
|
},
|
|
});
|